ci: fix mailchimp campaign schedule with meetings list #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derberg
requested review from
fmvilas,
quetzalliwrites and
asyncapi-bot-eve
as code owners
jonaslagoni
previously approved these changes
Apr 25, 2022
There was a problem hiding this comment.
Another alternative could be to make the cron-job run Sunday so it sends out the meeting list for Monday as we rarely (if ever) have any meetings that day. Would also mean we ping people when they start a new week ensuring they don't forget over the weekend 🤔
But yea 🤷
|
Yeah, I like @jonaslagoni proposal ☝️ |
|
@jonaslagoni @fmvilas let's try to send these on Monday then. We can always change it later. please accept folks |
jonaslagoni
approved these changes
Apr 25, 2022
fmvilas
approved these changes
Apr 25, 2022
|
/rtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, the first attempt to send a newsletter with a meetings list failed. Reason is that when you schedule campaign, it must be at least 24h in the future 🤦🏼 -> https://github.com/asyncapi/community/runs/6121221255?check_suite_focus=true
At the moment this PR introduces simple fix, but it means that because we run cron job midnight Thu/Fri then email with meetings list is sent out not 11:00AM Friday but 11:00AM Saturday.
I'm not 100% sure it is good.
Other options:
I think the best would be to modify this PR and do "until Wednesday schedule approach"
Thoughts?
@fmvilas @jonaslagoni asking you directly as you are hosts that will have to follow the changes